novaburst/funquail
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Fix #351: Ensure we do not import artists with empty names

Browse source
This commit is contained in:
Eliot Berriot 2018-07-09 22:35:32 +02:00
commit 93cd72ff09
No known key found for this signature in database
GPG key ID: DD6965E2476E5C27
4 changed files with 20 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

7
api/funkwhale_api/music/importers.py
View file

@ -3,12 +3,19 @@ def load(model, *args, **kwargs):
return importer.load(*args, **kwargs)
EXCLUDE_VALIDATION = {"Track": ["artist"]}
class Importer(object):
def __init__(self, model):
self.model = model
def load(self, cleaned_data, raw_data, import_hooks):
mbid = cleaned_data.pop("mbid")
# let's validate data, just in case
instance = self.model(**cleaned_data)
exclude = EXCLUDE_VALIDATION.get(self.model.__name__, [])
instance.full_clean(exclude=["mbid", "uuid"] + exclude)
m = self.model.objects.update_or_create(mbid=mbid, defaults=cleaned_data)[0]
for hook in import_hooks:
hook(m, cleaned_data, raw_data)