novaburst/funquail
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

See #297: removed a lot of unused variables

Browse source
This commit is contained in:
Eliot Berriot 2018-06-10 11:27:38 +02:00
commit 799386c2b6
No known key found for this signature in database
GPG key ID: DD6965E2476E5C27
28 changed files with 77 additions and 97 deletions
Download patch file Download diff file Expand all files Collapse all files

4
api/tests/playlists/test_models.py
View file

@ -106,7 +106,7 @@ def test_remove_update_indexes(factories):
def test_can_insert_many(factories):
playlist = factories["playlists.Playlist"]()
existing = factories["playlists.PlaylistTrack"](playlist=playlist, index=0)
factories["playlists.PlaylistTrack"](playlist=playlist, index=0)
tracks = factories["music.Track"].create_batch(size=3)
plts = playlist.insert_many(tracks)
for i, plt in enumerate(plts):
@ -118,7 +118,7 @@ def test_can_insert_many(factories):
def test_insert_many_honor_max_tracks(preferences, factories):
preferences["playlists__max_tracks"] = 4
playlist = factories["playlists.Playlist"]()
plts = factories["playlists.PlaylistTrack"].create_batch(size=2, playlist=playlist)
factories["playlists.PlaylistTrack"].create_batch(size=2, playlist=playlist)
track = factories["music.Track"]()
with pytest.raises(exceptions.ValidationError):
playlist.insert_many([track, track, track])

2
api/tests/playlists/test_serializers.py
View file

@ -4,7 +4,7 @@ from funkwhale_api.playlists import models, serializers
def test_cannot_max_500_tracks_per_playlist(factories, preferences):
preferences["playlists__max_tracks"] = 2
playlist = factories["playlists.Playlist"]()
plts = factories["playlists.PlaylistTrack"].create_batch(size=2, playlist=playlist)
factories["playlists.PlaylistTrack"].create_batch(size=2, playlist=playlist)
track = factories["music.Track"]()
serializer = serializers.PlaylistTrackWriteSerializer(
data={"playlist": playlist.pk, "track": track.pk}

6
api/tests/playlists/test_views.py
View file

@ -17,7 +17,7 @@ def test_can_create_playlist_via_api(logged_in_api_client):
def test_serializer_includes_tracks_count(factories, logged_in_api_client):
playlist = factories["playlists.Playlist"]()
plt = factories["playlists.PlaylistTrack"](playlist=playlist)
factories["playlists.PlaylistTrack"](playlist=playlist)
url = reverse("api:v1:playlists-detail", kwargs={"pk": playlist.pk})
response = logged_in_api_client.get(url)
@ -160,7 +160,7 @@ def test_can_add_multiple_tracks_at_once_via_api(
def test_can_clear_playlist_from_api(factories, mocker, logged_in_api_client):
playlist = factories["playlists.Playlist"](user=logged_in_api_client.user)
plts = factories["playlists.PlaylistTrack"].create_batch(size=5, playlist=playlist)
factories["playlists.PlaylistTrack"].create_batch(size=5, playlist=playlist)
url = reverse("api:v1:playlists-clear", kwargs={"pk": playlist.pk})
response = logged_in_api_client.delete(url)
@ -170,7 +170,7 @@ def test_can_clear_playlist_from_api(factories, mocker, logged_in_api_client):
def test_update_playlist_from_api(factories, mocker, logged_in_api_client):
playlist = factories["playlists.Playlist"](user=logged_in_api_client.user)
plts = factories["playlists.PlaylistTrack"].create_batch(size=5, playlist=playlist)
factories["playlists.PlaylistTrack"].create_batch(size=5, playlist=playlist)
url = reverse("api:v1:playlists-detail", kwargs={"pk": playlist.pk})
response = logged_in_api_client.patch(url, {"name": "test"})
playlist.refresh_from_db()