Fix #612: Improved accessibility by using main/section/nav tags and aria-labels in most critical places

This commit is contained in:
Eliot Berriot 2018-11-19 23:33:22 +01:00
commit 29171853b3
No known key found for this signature in database
GPG key ID: DD6965E2476E5C27
42 changed files with 1266 additions and 1122 deletions

View file

@ -1,6 +1,6 @@
<template>
<div v-title="labels.title">
<div class="ui vertical stripe segment">
<main v-title="labels.title">
<section class="ui vertical stripe segment">
<h2 class="ui header">
<translate>Browsing radios</translate>
</h2>
@ -86,60 +86,59 @@
:total="result.count"
></pagination>
</div>
</div>
</div>
</section>
</main>
</template>
<script>
import axios from 'axios'
import _ from 'lodash'
import $ from 'jquery'
import axios from "axios"
import _ from "lodash"
import $ from "jquery"
import logger from '@/logging'
import logger from "@/logging"
import OrderingMixin from '@/components/mixins/Ordering'
import PaginationMixin from '@/components/mixins/Pagination'
import TranslationsMixin from '@/components/mixins/Translations'
import RadioCard from '@/components/radios/Card'
import Pagination from '@/components/Pagination'
import OrderingMixin from "@/components/mixins/Ordering"
import PaginationMixin from "@/components/mixins/Pagination"
import TranslationsMixin from "@/components/mixins/Translations"
import RadioCard from "@/components/radios/Card"
import Pagination from "@/components/Pagination"
const FETCH_URL = 'radios/radios/'
const FETCH_URL = "radios/radios/"
export default {
mixins: [OrderingMixin, PaginationMixin, TranslationsMixin],
props: {
defaultQuery: {type: String, required: false, default: ''}
defaultQuery: { type: String, required: false, default: "" }
},
components: {
RadioCard,
Pagination
},
data () {
let defaultOrdering = this.getOrderingFromString(this.defaultOrdering || '-creation_date')
data() {
let defaultOrdering = this.getOrderingFromString(
this.defaultOrdering || "-creation_date"
)
return {
isLoading: true,
result: null,
page: parseInt(this.defaultPage),
query: this.defaultQuery,
paginateBy: parseInt(this.defaultPaginateBy || 12),
orderingDirection: defaultOrdering.direction || '+',
orderingDirection: defaultOrdering.direction || "+",
ordering: defaultOrdering.field,
orderingOptions: [
['creation_date', 'creation_date'],
['name', 'name']
]
orderingOptions: [["creation_date", "creation_date"], ["name", "name"]]
}
},
created () {
created() {
this.fetchData()
},
mounted () {
$('.ui.dropdown').dropdown()
mounted() {
$(".ui.dropdown").dropdown()
},
computed: {
labels () {
let searchPlaceholder = this.$gettext('Enter a radio name...')
let title = this.$gettext('Radios')
labels() {
let searchPlaceholder = this.$gettext("Enter a radio name...")
let title = this.$gettext("Radios")
return {
searchPlaceholder,
title
@ -147,7 +146,7 @@ export default {
}
},
methods: {
updateQueryString: _.debounce(function () {
updateQueryString: _.debounce(function() {
this.$router.replace({
query: {
query: this.query,
@ -157,7 +156,7 @@ export default {
}
})
}, 500),
fetchData: _.debounce(function () {
fetchData: _.debounce(function() {
var self = this
this.isLoading = true
let url = FETCH_URL
@ -167,34 +166,34 @@ export default {
name__icontains: this.query,
ordering: this.getOrderingAsString()
}
logger.default.debug('Fetching radios')
axios.get(url, {params: params}).then((response) => {
logger.default.debug("Fetching radios")
axios.get(url, { params: params }).then(response => {
self.result = response.data
self.isLoading = false
})
}, 500),
selectPage: function (page) {
selectPage: function(page) {
this.page = page
}
},
watch: {
page () {
page() {
this.updateQueryString()
this.fetchData()
},
paginateBy () {
paginateBy() {
this.updateQueryString()
this.fetchData()
},
ordering () {
ordering() {
this.updateQueryString()
this.fetchData()
},
orderingDirection () {
orderingDirection() {
this.updateQueryString()
this.fetchData()
},
query () {
query() {
this.updateQueryString()
this.fetchData()
}