make setting dynamic

Part-of: <https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/2607>

api/tests/conftest.py

@@ -429,8 +429,3 @@ def clear_license_cache(db):
 @pytest.fixture
 def faker():
     return factory.Faker._get_faker()
-
-
-@pytest.fixture()
-def dont_check_mbid(settings):
-    settings.ONLY_ALLOW_MUSICBRAINZ_TAGGED_FILES = False

api/tests/music/test_tasks.py

@@ -1402,7 +1402,8 @@ def test_fs_import(factories, cache, mocker, settings):
     assert "Pruning dangling tracks" in cache.get("fs-import:logs")[-1]
 
 
-def test_upload_checks_mbid_tag(temp_signal, factories, mocker):
+def test_upload_checks_mbid_tag(temp_signal, factories, mocker, preferences):
+    preferences["music__only_allow_musicbrainz_tagged_files"] = True
     mocker.patch("funkwhale_api.federation.routes.outbox.dispatch")
     mocker.patch("funkwhale_api.music.tasks.populate_album_cover")
     mocker.patch("funkwhale_api.music.metadata.Metadata.get_picture")

api/tests/test_import_audio_file.py

@@ -364,7 +364,7 @@ def test_handle_modified_update_existing_path_if_found_and_attributed_to(
     update_track_metadata.assert_not_called()
 
 
-def test_import_files(factories, capsys, dont_check_mbid):
+def test_import_files(factories, capsys):
     # smoke test to ensure the command run properly
     library = factories["music.Library"](actor__local=True)
     call_command(